Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mesh guide intro #4409

Merged
merged 14 commits into from
Jan 8, 2024
Merged

Update mesh guide intro #4409

merged 14 commits into from
Jan 8, 2024

Conversation

jasnonaz
Copy link
Contributor

@jasnonaz jasnonaz commented Nov 7, 2023

What are you changing in this pull request and why?

Tweaking / tightening / clarifying the language in the intro to the Mesh guide.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@jasnonaz jasnonaz requested a review from a team as a code owner November 7, 2023 15:49
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 11:19am

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address labels Nov 7, 2023
Copy link
Contributor

@dave-connors-3 dave-connors-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦞 !

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnonaz One tiny suggestion and then I suggest we 🚢 it!

- **Governance** - dbt's new governance features allow you to manage access to your dbt models both within and across projects.
- **[Groups](/docs/collaborate/govern/model-access#groups)** - groups allow you to assign models to subsets within a project.
- **Governance** - dbt's governance features allow you to manage access to your dbt models both within and across projects.
- **[Groups](/docs/collaborate/govern/model-access#groups)** - groups allow you to gather together nodes in your dbt DAG that are logically connected (such as by functional area) and assign an owner to the group.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we make this sentence active:

Suggested change
- **[Groups](/docs/collaborate/govern/model-access#groups)** - groups allow you to gather together nodes in your dbt DAG that are logically connected (such as by functional area) and assign an owner to the group.
- **[Groups](/docs/collaborate/govern/model-access#groups)** - With groups, you can organize nodes in your dbt DAG that share a logical connection (for example, by functional area) and assign an owner to the entire group.

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops lost this review. Very small suggestion to make sentence active. Otherwise ready to ship!

website/docs/best-practices/how-we-mesh/mesh-1-intro.md Outdated Show resolved Hide resolved
@mirnawong1
Copy link
Contributor

hey folks, looks like this is good to go so am going to merge this. let me know if you feel otherwise.

@runleonarun runleonarun merged commit f1a4b1d into current Jan 8, 2024
7 checks passed
@runleonarun runleonarun deleted the update-mesh-guide-intro branch January 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides January-2024 size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants