-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mesh guide intro #4409
Update mesh guide intro #4409
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦞 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnonaz One tiny suggestion and then I suggest we 🚢 it!
- **Governance** - dbt's new governance features allow you to manage access to your dbt models both within and across projects. | ||
- **[Groups](/docs/collaborate/govern/model-access#groups)** - groups allow you to assign models to subsets within a project. | ||
- **Governance** - dbt's governance features allow you to manage access to your dbt models both within and across projects. | ||
- **[Groups](/docs/collaborate/govern/model-access#groups)** - groups allow you to gather together nodes in your dbt DAG that are logically connected (such as by functional area) and assign an owner to the group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we make this sentence active:
- **[Groups](/docs/collaborate/govern/model-access#groups)** - groups allow you to gather together nodes in your dbt DAG that are logically connected (such as by functional area) and assign an owner to the group. | |
- **[Groups](/docs/collaborate/govern/model-access#groups)** - With groups, you can organize nodes in your dbt DAG that share a logical connection (for example, by functional area) and assign an owner to the entire group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops lost this review. Very small suggestion to make sentence active. Otherwise ready to ship!
Co-authored-by: Leona B. Campbell <[email protected]>
hey folks, looks like this is good to go so am going to merge this. let me know if you feel otherwise. |
What are you changing in this pull request and why?
Tweaking / tightening / clarifying the language in the intro to the Mesh guide.
Checklist